Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom_authorizer_connect policy #502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update custom_authorizer_connect policy #502

wants to merge 3 commits into from

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented May 24, 2024

Issue #, if available:
#501

Description of changes:
Update custom_authorizer_connect policy

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmklix jmklix linked an issue May 24, 2024 that may be closed by this pull request
Policy for /browser/custom_authorizer_connect sample project is missing details #501
Open
bretambrose
bretambrose reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a larger issue that "thing" and its policy are irrelevant to custom auth. A larger change needs to be made here (and possibly the other SDK sample readmes as well)

@jmklix
Copy link
Member Author

jmklix commented Aug 12, 2024

@bretambrose What larger changes should be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretambrose bretambrose bretambrose left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy for /browser/custom_authorizer_connect sample project is missing details
2 participants
@jmklix @bretambrose