Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix missing getVersion in nightly Dafny CI #883

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

alex-chew
Copy link
Contributor

Fixes startup failures like https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/11389253918

The getVersion job definition is copied from

getVersion:
# Don't run the cron builds on forks
if: github.event_name != 'schedule' || github.repository_owner == 'aws'
uses: ./.github/workflows/dafny_version.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alex-chew alex-chew requested a review from a team as a code owner October 17, 2024 22:25
@alex-chew
Copy link
Contributor Author

alex-chew commented Oct 17, 2024

Test run of nightly: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/11394157649

Note that it fails as expected due to a different error related to an out-of-date Smithy dependency. The fact that the jobs run at all indicates that the PR successfully fixes the invalid workflow file.

@robin-aws robin-aws merged commit 15a134c into main Oct 21, 2024
97 of 157 checks passed
@robin-aws robin-aws deleted the ci/fix-missing-get-version-job branch October 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants