-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: StandardLibrary Externs #418
Conversation
StandardLibrary/runtimes/python/src/standard_library/internaldafny/extern/DafnyLibraries.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested interoperability with .net? I'm slightly nervous about L36 that encodes to utf-16-be. We ran into some BigEndianness issues in .net with ECDH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have known value tests:
- https://github.com/aws/aws-cryptographic-material-providers-library/blob/main/StandardLibrary/test/TestComputeSetToOrderedSequenceUInt8Less.dfy
- https://github.com/aws/aws-cryptographic-material-providers-library/blob/main/StandardLibrary/test/TestComputeSetToOrderedSequenceCharLess.dfy
So not specifically NET.
StandardLibrary/runtimes/python/src/standard_library/internaldafny/extern/Time.py
Outdated
Show resolved
Hide resolved
StandardLibrary/runtimes/python/src/standard_library/internaldafny/extern/UTF8.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some questions :)
…afny/extern/UTF8.py Co-authored-by: José Corella <[email protected]>
@lucasmcdonald3, I noticed you are updating the smithy model files. |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
@lucasmcdonald3, I noticed you are updating the smithy model files. |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
@lucasmcdonald3, I noticed you are updating the smithy model files. |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
@lucasmcdonald3, I noticed you are updating the smithy model files. |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.