Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: StandardLibrary Externs #418

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested interoperability with .net? I'm slightly nervous about L36 that encodes to utf-16-be. We ran into some BigEndianness issues in .net with ECDH

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some questions :)

Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?

Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?

Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?

Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

Detected changes to the release files or to the check-files action

Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucasmcdonald3 lucasmcdonald3 merged commit 3ac8ef0 into python-reviewed Jul 24, 2024
52 of 56 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the python-stdlib-extern branch October 5, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants