chore: Fix verification and formatting errors #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
changed the title
robin-aws
changed the title
|
I did a dry run and found this doesn't fix all errors yet: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/8824262108/job/24226358594 The formatting one is just a CI issue, in that it doesn't apply the patches before checking the formatting. I can fix that easily. The other failure is because verification succeeds but the report generator rejects one of the most expensive assertion batches: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/8824262108/job/24226362691#step:10:948 Can you have a look at that one @atomb? |
…ic-material-providers-library-dafny into build-fix-2024-04-19
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
…ic-material-providers-library-dafny into build-fix-2024-04-19
texastony
approved these changes
Apr 29, 2024
lucasmcdonald3
pushed a commit
that referenced
this pull request
Jun 4, 2024
ajewellamz
pushed a commit
that referenced
this pull request
Dec 18, 2024
--------- Co-authored-by: Lucas McDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix verification and formatting errors. This should allow both Dafny 4.2.0 and nightly to work.
Dry-run of nightly build on this branch: https://github.com/aws/aws-cryptographic-material-providers-library/actions/runs/8883856511/job/24391619483
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.