Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(.NET): CollectionOfErrors; list as string #1247

Merged
merged 8 commits into from
Jan 23, 2025
Merged

chore(.NET): CollectionOfErrors; list as string #1247

merged 8 commits into from
Jan 23, 2025
+229 −28

Conversation

josecorella
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@josecorella josecorella changed the base branch from dotnet/before-shared-cache to dotnet/after-1.7.0 January 23, 2025 20:17
@josecorella josecorella changed the base branch from dotnet/after-1.7.0 to dotnet/after-1.7.4 January 23, 2025 20:24
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

texastony
texastony approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

@josecorella and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@josecorella josecorella force-pushed the jocorell/collection-of-errors branch from 4d2a557 to ff2de65 Compare January 23, 2025 20:46
@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@github-actions GitHub Actions
Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

texastony
texastony approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

@josecorella and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@josecorella josecorella marked this pull request as ready for review January 23, 2025 21:28
@josecorella josecorella requested a review from a team as a code owner January 23, 2025 21:28
RitvikKapila
RitvikKapila approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@RitvikKapila RitvikKapila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

@josecorella and @RitvikKapila, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions GitHub Actions
Copy link

Detected changes to the release files or to the check-files action

@josecorella josecorella merged commit 80b6b2e into dotnet/after-1.7.4 Jan 23, 2025
108 checks passed
@josecorella josecorella deleted the jocorell/collection-of-errors branch January 23, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitvikKapila RitvikKapila RitvikKapila approved these changes

@texastony texastony texastony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josecorella @texastony @RitvikKapila @lucasmcdonald3