Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mpl): Go release v0.0.1 #1211

Merged
merged 4 commits into from
Jan 15, 2025
Merged

feat(mpl): Go release v0.0.1 #1211

merged 4 commits into from
Jan 15, 2025

Conversation

ShubhamChaturvedi7
Copy link
Contributor

Issue #, if available:

Description of changes:

Initial release based on MPL 1.8.0.

Files to be reviewed:
README.md
LICENSE
CHANGELOG.md
externs (Copied over from checked-in code / Optional)
go.mod (Copied over from checked-in code / Optional)

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ShubhamChaturvedi7 ShubhamChaturvedi7 requested a review from a team as a code owner January 14, 2025 22:31
rishav-karanjit
rishav-karanjit approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@rishav-karanjit rishav-karanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a non blocking comment. Without it as well it looks good to me.

releases/go/mpl/README.md Show resolved Hide resolved
rishav-karanjit
rishav-karanjit requested changes Jan 14, 2025
View reviewed changes
releases/go/mpl/README.md Outdated Show resolved Hide resolved
seebees
seebees reviewed Jan 14, 2025
View reviewed changes
releases/go/mpl/README.md Outdated Show resolved Hide resolved
rishav-karanjit
rishav-karanjit approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@rishav-karanjit rishav-karanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShubhamChaturvedi7 ShubhamChaturvedi7 merged commit 4508ab8 into main Jan 15, 2025
168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seebees seebees seebees left review comments

@rishav-karanjit rishav-karanjit rishav-karanjit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamChaturvedi7 @seebees @rishav-karanjit