-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-resources): incorrect IAM prefix generated for CloudWatch actions #33078
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33078 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 226 226
Lines 13777 13777
Branches 2414 2414
=======================================
Hits 11235 11235
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
f64d0b2
to
3f74d79
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32968.
Reason for this change
The mapping to look up the IAM prefix from a given service has a incorrect entry for Cloudwatch. It says Cloudwatch uses
monitoring
as the prefix but it is actuallycloudwatch
instead.I cannot find any service that uses
monitoring
as prefix so I think it is safe to assume that nothing relies on themonitoring
value. Therefore, there is no feature flag used in this PR.Description of changes
Updated the IAM prefix mapping.
Describe any new or updated permissions being added
Updated the mapping to use correct IAM prefix.
Description of how you validated changes
Updated unit tests to use AwsCustomResource with a Cloudwatch call.
Added integ test to use AwsCustomResource with a Cloudwatch call to tag an alarm and verify the tag is indeed added successfully.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license