Add configuration check for env WARM_IP_TARGET and MINIMUM_IP_TARGET #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
suggested changes
Nov 8, 2023
oliviassss
force-pushed
the
update-default-env
branch
from
e447bae to
beab647
Compare
|
As discussed internally, we decided not to change the default value of |
oliviassss
changed the title
jdn5126
reviewed
Nov 9, 2023
jdn5126
force-pushed
the
update-default-env
branch
from
1cfaef7 to
74987dd
Compare
jdn5126
suggested changes
Nov 14, 2023
jdn5126
previously approved these changes
Nov 14, 2023
jayanthvn
reviewed
Nov 14, 2023
jayanthvn
reviewed
Nov 14, 2023
oliviassss
force-pushed
the
update-default-env
branch
2 times, most recently
from
541e76d to
4fd8463
Compare
jdn5126
force-pushed
the
update-default-env
branch
from
4fd8463 to
06a14a1
Compare
jdn5126
force-pushed
the
update-default-env
branch
from
06a14a1 to
89e4cc5
Compare
jdn5126
force-pushed
the
update-default-env
branch
from
89e4cc5 to
0dc4cd7
Compare
jayanthvn
reviewed
Dec 13, 2023
jayanthvn
reviewed
Dec 13, 2023
jayanthvn
reviewed
Dec 13, 2023
jayanthvn
requested changes
Dec 13, 2023
jdn5126
force-pushed
the
update-default-env
branch
from
0dc4cd7 to
e603ce3
Compare
That is covered. When MIN IP is set, WARM ENI is ignored, though |
jdn5126
force-pushed
the
update-default-env
branch
from
e603ce3 to
6cec4af
Compare
jdn5126
previously approved these changes
Dec 18, 2023
jdn5126
reviewed
Dec 19, 2023
jchen6585
force-pushed
the
update-default-env
branch
from
1c64866 to
9038482
Compare
|
Closing this PR as we have chosen to update the README to call this behavior out instead: https://github.com/aws/amazon-vpc-cni-k8s#minimum_ip_target-v160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fix
Which issue does this PR fix:
#2650
What does this PR do / Why do we need it:
This PR adds a configuration check on env, if
MINIMUM_IP_TARGETis set butWARM_IP_TARGETis not set, it will error out. Also update docs on this change.Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.