Fix CDK deployment #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
approved these changes
Oct 17, 2024
| break; | ||
| case '-cd': | ||
| // support miss-spelled option for backwards compatibility - could be removed for next major release | ||
| case '--output-aws-pipeline-cdk-neptume-database-name': |
…rized errors when using the deployed GraphQL API app: -VPC config now has the appropriate subnets and security group configured -policy actions now reference the correct aws service depending on the neptune type -environment now references the correct region when the neptune type is neptune-graph -refactored endpoint parsing to use new util function so that the logic is contained in place and parsing is done in one function call instead of sprinkled throughout the code -added unit tests for endpoint parsing -added integration test verification for CDK deployment to check that the generated CDK js file contains some expected content
andreachild
force-pushed
the
achild/fixCdk
branch
from
080765d
to
5f41c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed CDK lambda function bugs which were causing timeout and unauthorized errors when using the deployed GraphQL API app: