Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename pOrganizationName parameter to pOrg to be consistent across all SDLF #250

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdlf-dataset/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ Parameters:
pPipelineReference:
Type: String
Default: none
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pDomain:
Description: Data domain name
Type: String
Expand All @@ -17,10 +21,6 @@ Parameters:
Description: Environment name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pEnv}}"
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pStageBucket:
Description: The stage bucket for the solution
Type: String
Expand Down
46 changes: 23 additions & 23 deletions sdlf-foundations/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Parameters:
Type: String
AllowedPattern: (\d{12}|^$)
ConstraintDescription: Must be an AWS account ID
pOrg:
Description: Name of the organization owning the datalake (all lowercase, no symbols or spaces)
Type: String
AllowedPattern: "[a-z0-9]{2,9}"
pDomain:
Description: Data domain name
Type: String
Expand All @@ -27,10 +31,6 @@ Parameters:
Type: String
AllowedValues: ["3", "1"]
ConstraintDescription: Must specify 3 or 1
pOrganizationName:
Description: Name of the organization (all lowercase, no symbols or spaces)
Type: String
AllowedPattern: "[a-z0-9]{2,9}"
pCloudWatchLogsRetentionInDays:
Description: The number of days log events are kept in CloudWatch Logs
Type: Number
Expand Down Expand Up @@ -344,7 +344,7 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-s3logs",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-s3logs",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-s3logs",
]
LifecycleConfiguration:
Rules:
Expand Down Expand Up @@ -391,7 +391,7 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "arn:${AWS::Partition}:s3:::${pCustomBucketPrefix}*",
!Sub "arn:${AWS::Partition}:s3:::${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}*",
!Sub "arn:${AWS::Partition}:s3:::${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}*",
]
StringEquals:
"aws:SourceAccount": !Sub ${AWS::AccountId}
Expand Down Expand Up @@ -460,15 +460,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-artifacts",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-artifacts",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-artifacts",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-artifacts",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-artifacts",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-artifacts",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -510,15 +510,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Ref pCustomBucketPrefix,
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Ref pCustomBucketPrefix,
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -574,15 +574,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-raw",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-raw",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -638,15 +638,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-stage",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-stage",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -702,15 +702,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-analytics",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-analytics",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -764,15 +764,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-athena",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-athena",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-athena",
]
LoggingConfiguration:
DestinationBucketName: !Ref rS3AccessLogsBucket
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-athena",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-athena",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-athena",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -902,11 +902,11 @@ Resources:
!If [
CreateMultipleBuckets,
[
!Sub "arn:${AWS::Partition}:s3:::${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
!Sub "arn:${AWS::Partition}:s3:::${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
!Sub "arn:${AWS::Partition}:s3:::${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
!Sub "arn:${AWS::Partition}:s3:::${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-raw",
!Sub "arn:${AWS::Partition}:s3:::${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-stage",
!Sub "arn:${AWS::Partition}:s3:::${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-analytics",
],
!Sub "arn:${AWS::Partition}:s3:::${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
!Sub "arn:${AWS::Partition}:s3:::${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
],
]
StringEquals:
Expand Down Expand Up @@ -1635,7 +1635,7 @@ Resources:
Properties:
Name: /SDLF/Misc/pOrg
Type: String
Value: !Ref pOrganizationName
Value: !Ref pOrg
Description: Name of the Organization owning the datalake

rDomainSsm:
Expand Down
10 changes: 5 additions & 5 deletions sdlf-monitoring/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Description: Monitoring stack - SNS, CloudTrail, StorageLens, CloudWatch Dashboa
Parameters:
pDomain:
Type: String
pOrg:
Type: String
pEnvironment:
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pEnv:1}}"
Expand All @@ -21,8 +23,6 @@ Parameters:
Description: Optional The log file prefix.
Type: String
Default: ""
pOrganizationName:
Type: String
pOpenSearchDomain:
Description: OpenSearch domain name
Type: String
Expand Down Expand Up @@ -256,15 +256,15 @@ Resources:
!If [
UseCustomBucketPrefix,
!Sub "${pCustomBucketPrefix}-cloudtrail",
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-cloudtrail",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}-cloudtrail",
]
LoggingConfiguration:
DestinationBucketName: "{{resolve:ssm:/SDLF/S3/AccessLogsBucket}}"
LogFilePrefix:
!If [
UseCustomBucketPrefix,
!Ref pCustomBucketPrefix,
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down Expand Up @@ -753,7 +753,7 @@ Resources:
!If [
UseCustomBucketPrefix,
!Ref pCustomBucketPrefix,
!Sub "${pOrganizationName}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
!Sub "${pOrg}-${pDomain}-${pEnvironment}-${AWS::Region}-${AWS::AccountId}",
]
BucketEncryption:
ServerSideEncryptionConfiguration:
Expand Down
8 changes: 4 additions & 4 deletions sdlf-stage-dataquality/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ Parameters:
Description: Workaround for CloudFormation resolve:ssm not updating on stack update (https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/844)
Type: String
Default: none
pDomain:
Description: Data domain name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pDomain}}"
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pDomain:
Description: Data domain name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pDomain}}"
pTeamName:
Description: Name of the team owning the pipeline (all lowercase, no symbols or spaces)
Type: String
Expand Down
18 changes: 9 additions & 9 deletions sdlf-stageA/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ Parameters:
Description: Workaround for CloudFormation resolve:ssm not updating on stack update (https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/844)
Type: String
Default: none
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pDomain:
Description: Data domain name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pDomain}}"
pDatasetBucket:
Description: The raw or central bucket for the solution
Type: String
Expand All @@ -15,14 +23,6 @@ Parameters:
Description: The stage bucket for the solution
Type: String
Default: "{{resolve:ssm:/SDLF/S3/StageBucket}}"
pDomain:
Description: Data domain name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pDomain}}"
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pTeamName:
Description: Name of the team owning the pipeline (all lowercase, no symbols or spaces)
Type: String
Expand Down Expand Up @@ -741,4 +741,4 @@ Resources:
Outputs:
oPipelineReference:
Description: CodePipeline reference this stack has been deployed with
Value: !Ref pPipelineReference
Value: !Ref pPipelineReference
14 changes: 7 additions & 7 deletions sdlf-stageB/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@ Parameters:
Description: Workaround for CloudFormation resolve:ssm not updating on stack update (https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/844)
Type: String
Default: none
pDatasetBucket:
Description: The raw or central bucket for the solution
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/S3/CentralBucket}}"
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
pDomain:
Description: Data domain name
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pDomain}}"
pOrg:
Description: Name of the organization owning the datalake
pDatasetBucket:
Description: The raw or central bucket for the solution
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
Default: "{{resolve:ssm:/SDLF/S3/CentralBucket}}"
pTeamName:
Description: Name of the team owning the pipeline (all lowercase, no symbols or spaces)
Type: String
Expand Down Expand Up @@ -625,4 +625,4 @@ Resources:
Outputs:
oPipelineReference:
Description: CodePipeline reference this stack has been deployed with
Value: !Ref pPipelineReference
Value: !Ref pPipelineReference
8 changes: 4 additions & 4 deletions sdlf-team/template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Parameters:
pPipelineReference:
Type: String
Default: none
pOrganizationName:
pOrg:
Description: Name of the organization owning the datalake
Type: String
Default: "{{resolve:ssm:/SDLF/Misc/pOrg}}"
Expand Down Expand Up @@ -500,10 +500,10 @@ Resources:
- glue:GetDataQualityRulesetEvaluationRun
Resource:
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:catalog
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:database/${pOrganizationName}_${pDomain}_${pEnvironment}_${pTeamName}_*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:table/${pOrganizationName}_${pDomain}_${pEnvironment}_${pTeamName}_*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:database/${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:table/${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:job/sdlf-${pTeamName}-*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:job/${pOrganizationName}-${pDomain}-${pEnvironment}-${pTeamName}-*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:job/${pOrg}-${pDomain}-${pEnvironment}-${pTeamName}-*
- !Sub arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:dataQualityRuleset/* # glue:StartDataQualityRuleRecommendationRun requires dataQualityRuleset/*
- Effect: Allow
Action:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Resources:
Properties:
pPipelineReference: !Ref pPipelineReference
pChildAccountId: !Ref "AWS::AccountId"
pOrganizationName: forecourt
pOrg: forecourt
pDomain: datalake
pEnvironment: dev
pNumBuckets: 3
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Resources:
Properties:
pPipelineReference: !Ref pPipelineReference
pChildAccountId: 222222222222
pOrganizationName: forecourt
pOrg: forecourt
pDomain: marketing
pEnvironment: dev
pNumBuckets: 3
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Resources:
Properties:
pPipelineReference: !Ref pPipelineReference
pChildAccountId: 111111111111
pOrganizationName: forecourt
pOrg: forecourt
pDomain: proserve
pEnvironment: dev
pNumBuckets: 3