Transform data quality steps into a proper sdlf stage (sdlf-stage-dataquality) #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove data-quality-controller job, run suggestions and verification jobs directly from the state machine remove crawl-data lambda, run glue crawler directly from the state machine remove check-job lambda, the state-machine handles it with glue .sync integration better lambda error handling remove dedicated data quality bucket, use central bucket/stage bucket instead remove dedicated glue crawler, use crawler defined in sdlf-dataset instead optional vpc support: specify boto3 client endpoint, vpc config for lambda functions
run glue data quality recommendations and ruleset evaluation directly from the step functions instead of inside a glue job glue data quality stores recommendations and rulesets - retire dedicated dynamodb table piggyback on sdlf-dataset pPipelineDetails to provide list of glue tables to run data quality stage against
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#157
Description of changes:
Run Glue Data Quality recommendations and ruleset evaluation directly from the step functions instead of inside a Glue job.
Glue Data Quality stores recommendations and rulesets - retire dedicated dynamodb table. Also piggyback on sdlf-dataset
pPipelineDetailsto provide a list of glue tables to run data quality stage against.With the work done in #235 by @mureddy19, this closes #157.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.