Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrectly named variable in the for loop which deletes legacy… #243

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

waltmayfield
Copy link

@waltmayfield waltmayfield commented Jan 17, 2024

… domains

Issue #, if available:
Deleting legacy domains would fail b/c the delete_domain_cicd_stack function was given an incorrectly named domain variable.
for legacy_domain in legacy_domains:
stack_details = delete_domain_cicd_stack(domain, environment, cloudformation_role)

Here's the error you get when triggering the delete_domain_cicd_stack funciton from the for loop:
[ERROR] UnboundLocalError: cannot access local variable 'domain' where it is not associated with a value
Traceback (most recent call last):
File "/var/task/lambda_function.py", line 247, in lambda_handler
stack_details = delete_domain_cicd_stack(domain, environment, cloudformation_role)

Description of changes:
I changed domain to legacy_domain in the delete_domain_cicd_stack argument.
Also my Amazon email address is [email protected]. Would love to contribute to this project!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cnfait cnfait merged commit df23573 into aws-solutions-library-samples:main Jan 17, 2024
2 of 3 checks passed
@cnfait
Copy link
Contributor

cnfait commented Jan 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants