Fixed incorrectly named variable in the for loop which deletes legacy… #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… domains
Issue #, if available:
Deleting legacy domains would fail b/c the delete_domain_cicd_stack function was given an incorrectly named domain variable.
for legacy_domain in legacy_domains:
stack_details = delete_domain_cicd_stack(domain, environment, cloudformation_role)
Here's the error you get when triggering the delete_domain_cicd_stack funciton from the for loop:
[ERROR] UnboundLocalError: cannot access local variable 'domain' where it is not associated with a value
Traceback (most recent call last):
File "/var/task/lambda_function.py", line 247, in lambda_handler
stack_details = delete_domain_cicd_stack(domain, environment, cloudformation_role)
Description of changes:
I changed domain to legacy_domain in the delete_domain_cicd_stack argument.
Also my Amazon email address is [email protected]. Would love to contribute to this project!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.