Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplitude Personalize Workshop #41

Merged

Conversation

manbearshark
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* WIP - Adding content outline for Braze config steps

* WIP - Added template create images

* WIP - Added steps content, shrunk Retina imgs

* WIP - Create Template updates

* WIP - Added Personalize arch diagram

* WIP - Updated arch image

* WIP - Updated arch section

* WIP - Arch overview updates

* WIP - Moved template files

* WIP - Updated arch dia and numbered lists

* WIP - Test numbering fix

* WIP - Added users CSV file

- Removed .zip from .gitignore

* WIP - Added user upload content

* WIP - Added segment creation

* WIP - Added campaign creation

* WIP - Campaign content

* WIP - Added email example images + verbiage

* Added ELB lookup and response exploration

* WIP - Editing sample code for recommendations service test

* Service lookups and demo rec query

* Sample email image change

* Updated to support automated user creation

* Removed CSV references

* Andys updates

* WIP - Adding content outline for Braze config steps

* WIP - Added template create images

* WIP - Added steps content, shrunk Retina imgs

* WIP - Create Template updates

* WIP - Added Personalize arch diagram

* WIP - Updated arch image

* WIP - Updated arch section

* WIP - Arch overview updates

* WIP - Moved template files

* WIP - Updated arch dia and numbered lists

* WIP - Test numbering fix

* WIP - Added users CSV file

- Removed .zip from .gitignore

* WIP - Added user upload content

* WIP - Added segment creation

* WIP - Added campaign creation

* WIP - Campaign content

* WIP - Added email example images + verbiage

* Added ELB lookup and response exploration

* WIP - Editing sample code for recommendations service test

* Service lookups and demo rec query

* Sample email image change

* Updated to support automated user creation

* Removed CSV references

* Andys updates

* gitignore fix

* Remove local references

* Template detail screen shot

* jupyter download instructions
Copy link
Contributor

@james-jory james-jory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a great workshop! Some things to look at before it's ready.

  • Source files require license statements at the top. See generate_users_json.py for example.
  • Add requirements.txt for datagenerator.
  • Seems like the datagenerator directory could benefit from a README.
  • Is the generate_users_json.py obsolete now? Can datagenerator be used to rebuild just the users JSON file or maybe generate_users_json.py can use datagenerator to create the users?

manbearshark and others added 17 commits June 11, 2020 12:16
…ark/retail-demo-store into amplitude-personalize-workshop

* 'amplitude-personalize-workshop' of github.com:manbearshark/retail-demo-store:
  Data reference and stage copy update
  User ID to string
  Staged Amplitude deploy
  Search report images and content
  Adding final steps
  Fixed SSM query issue
  Fixed settings image
  Additional config steps
  Users file read + SSM config read
  Fix for file paths
  Datagenerator library + Amplitude reports
  Post personalize part I
  More detail on post-personalize reports
  Switched config file name
  Post personalization features
  Added Amplitude notebook
Copy link
Contributor

@james-jory james-jory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: at the top of the workshop, should the first reference to "Amplitude" be hyperlinked to their website? What about adding a brief "About Amplitude" section that explains what Amplitude is and does? Some readers may not be familiar with them.

Also, I was surprised to see all the Braze workshop files in this PR too.

Hyperlink in first sentence in the "Create Amplitude Conversion Reports" section of the notebook is malformed. Looks like you have parens and square brackets in wrong places.

generators/README.md Outdated Show resolved Hide resolved
generators/README.md Outdated Show resolved Hide resolved
generators/README.md Outdated Show resolved Hide resolved
@james-jory james-jory merged commit 2708908 into aws-samples:master Jun 19, 2020
daemon-joe pushed a commit to Daemon-Solutions/retail-demo-store that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants