Image preview dialog #199
Merged
Image preview dialog #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
reviewed
Mar 27, 2024
| onAfterLeave: () => void; | ||
| }; | ||
|
|
||
| const ImagePreview: React.FC<ImagePreviewProps> = (props) => { |
There was a problem hiding this comment.
ModalDialogとほぼ同じなので、統一できないでしょうか？
titleとonAfterLeaveの部分を改造すれば、共通化できそうな気がします
| @@ -107,6 +115,13 @@ const ChatMessage: React.FC<Props> = (props) => { | |||
| ); | |||
| } | |||
| })} | |||
| <ImagePreview | |||
There was a problem hiding this comment.
コメント位置が適切ではないですが・・・
以下のメッセージ入力欄のものも拡大表示できないでしょうか？
There was a problem hiding this comment.
拡大できるようにしました。全く同じスタイルをあてています
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Preview image dialog on message
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.