Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce task startup time for embedding job #185

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

tmokmss
Copy link
Contributor

@tmokmss tmokmss commented Mar 25, 2024

Issue #, if available:

Description of changes:

What I did:

  • Enable SOCI index
  • install only chromium for playwright

Result:

  • Image size is reduced by 200MB(compressed) (3900MB -> 3700MB)
  • Task startup time is reduced by 80% (157s avg -> 32s avg)

I also added .prettierrc for consistent formatting, following the current format rule (I guess).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Enable SOCI index
install only chromium for playwright
@statefb
Copy link
Contributor

statefb commented Mar 25, 2024

  • 80% of task launches were accelerated
    • The deterioration in task execution speed due to lazy loading was within an acceptable level this time (+about 10 seconds)

@statefb statefb merged commit e98a3b5 into main Mar 25, 2024
6 checks passed
@statefb
Copy link
Contributor

statefb commented Mar 25, 2024

LGTM, thank you for your contribution!

@statefb statefb deleted the faster_task_launch branch March 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants