Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create manifest.json and modify index.html to enable the web app to be saved in iOS homescreen as an icon. #176

Merged
merged 5 commits into from
Apr 7, 2024

Conversation

amaynez
Copy link
Contributor

@amaynez amaynez commented Mar 21, 2024

manifest.json enables the web app to be saved in iOS homescreen as an icon.

Issue #, if available:

Description of changes:
Added a manifesto.json to enable webapp behaviour in iOS devices

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

manifest.json enables the web app to be saved in iOS homescreen as an icon.
@wadabee wadabee self-requested a review March 24, 2024 08:05
Copy link
Contributor

@wadabee wadabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR to improve mobile UX!
Please respond to my comment.
Also, please merge #177 into this PR as it is relevant here!

frontend/src/manifest.json Outdated Show resolved Hide resolved
frontend/src/manifest.json Outdated Show resolved Hide resolved
@amaynez amaynez changed the title Create manifest.json Create manifest.json and modify index.html to enable the web app to be saved in iOS homescreen as an icon. Mar 27, 2024
@amaynez
Copy link
Contributor Author

amaynez commented Mar 27, 2024

Thanks for the PR to improve mobile UX! Please respond to my comment. Also, please merge #177 into this PR as it is relevant here!

Changes applied and both Pull Requests merged.

@amaynez amaynez requested a review from wadabee March 27, 2024 19:34
@wadabee wadabee merged commit 796ed68 into aws-samples:main Apr 7, 2024
2 checks passed
@wadabee
Copy link
Contributor

wadabee commented Apr 7, 2024

LGTM! Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants