-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Google Auth #128
Feature: Add Google Auth #128
Conversation
@kyosuke-kobayashi-lvgs PRありがとうございます!! |
@kyosuke-kobayashi-lvgs
const oidcSecret = secretsmanager.Secret.fromSecretNameV2(this, "Secret", "cdk.jsonからの値");
最初にお伝えすべき点もいくつかあり後出しのような形になってしまい申し訳ありません。よろしくお願いします! |
(本PRとは別ですが)contribution自体はとても嬉しいです!!!!ですが、機能を実装される前に、一度Issue -> Feature Requestを起票し、一度相談していただけると大変助かりますmm |
@statefb |
合わせてcdk.yml にcdk test のjobを追加しております! |
cdk/test/cdk.test.ts
Outdated
} | ||
); | ||
|
||
hasGoogleProviderTemplate.hasResource("AWS::Cognito::UserPoolClient", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependsのテストを書かれているのには何か理由がありますか?
Logical IDはpath依存のため今後リファクタリングが行われた場合こちらのテストも書き直す必要が生じると思いますが、手間と必要性を天秤にかけると無くても良いかと思いました
参考
CDK generates the Logical IDs based on the full Construct “path”. With nested Constructs, IDs of all “higher” Constructs are used to create the unique Logical ID. So when the path changed from MyQueue to MyCustomQueue/MyQueue, the generated Logical ID changed from MyQueueE6CA6235 to MyCustomQueueMyQueue20F468EB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
論理 ID はパス依存のため今後リファクタリングが行われた場合こちらのテストも書き直す必要が生じると思いますが
こちらの観点考慮できておりませんでしたmm
現在のhasResourcePropertiesでの式でも、今回テストしたい範囲は十分にテストされているかと思うのでご指摘いただいた通り、該当テスト削除します!
cdk/test/cdk.test.ts
Outdated
}); | ||
const template = Template.fromStack(stack); | ||
|
||
// template.hasResourceProperties("AWS::Cognito::UserPool", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIPは消してください!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すいません!失礼しました!
This reverts commit 6eb0c1e.
LGTM!! |
Issue #, if available:
Description of changes:
SSOできるようにしました
※別途GCPで認証プロバイダーのClientKeyとSecretをSecretManagerに登録する必要があります
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.