Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfiles to build with python3, update urlparse import for … #32

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

ctcudd
Copy link
Contributor

@ctcudd ctcudd commented Aug 12, 2020

Update Dockerfiles to build with python3, update urlparse import for python3 and move to compatible/more recent version of requests library.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…python3 and move to compatible/more recent version of requests library
@ctcudd ctcudd mentioned this pull request Aug 12, 2020
@MitchyBAwesome
Copy link
Collaborator

This looks good and seems to address most of the dependency challenges reported recently. @amui @hub714 Any other observations before merging?

@MitchyBAwesome MitchyBAwesome self-assigned this Aug 25, 2020
@MitchyBAwesome MitchyBAwesome requested review from amui and hub714 August 25, 2020 22:08
Copy link
Contributor

@hub714 hub714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and is also what needs to be changed on the main MAD workshop too.

Copy link
Contributor

@amui amui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some tweaks to readme are needed, but will do that separately.

@amui amui merged commit 1105c98 into aws-samples:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants