Close LED device on correct Thread (#803)

awawa-dev · Mar 23, 2024 · 52f12b4 · 52f12b4
1 parent eaf76af
commit 52f12b4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/sources/leddevice/LedDeviceWrapper.cpp b/sources/leddevice/LedDeviceWrapper.cpp
@@ -56,7 +56,7 @@ void LedDeviceWrapper::createLedDevice(QJsonObject config, int smoothingInterval
 	_ledDevice = std::unique_ptr<LedDevice, void(*)(LedDevice*)>(
 		LedDeviceFactory::construct(config),
 		[](LedDevice* oldLed) {
-			oldLed->stop();
+			QUEUE_CALL_0(oldLed, stop);
 			hyperhdr::THREAD_REMOVER(QString("LedDevice"), oldLed->thread(), oldLed);
 		}
 	);

diff --git a/sources/leddevice/dev_rpi_pwm/LedDeviceWS281x.cpp b/sources/leddevice/dev_rpi_pwm/LedDeviceWS281x.cpp
@@ -69,7 +69,7 @@ bool LedDeviceWS281x::init(const QJsonObject& deviceConfig)
 				Debug(_log, "ws281x strip type       : %d", _ledString->channel[_channel].strip_type);
 
 				if (_defaultInterval > 0)
-					Error(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
+					Warning(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
 
 				isInitOK = true;
 			}

diff --git a/sources/leddevice/dev_serial/ProviderSerial.cpp b/sources/leddevice/dev_serial/ProviderSerial.cpp
@@ -73,7 +73,7 @@ bool ProviderSerial::init(const QJsonObject& deviceConfig)
 		Debug(_log, "Retry limit   : %d", _maxRetry);
 
 		if (_defaultInterval > 0)
-			Error(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
+			Warning(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
 
 		isInitOK = true;
 	}

diff --git a/sources/leddevice/dev_spi/ProviderSpi.cpp b/sources/leddevice/dev_spi/ProviderSpi.cpp
@@ -53,7 +53,7 @@ bool ProviderSpi::init(const QJsonObject& deviceConfig)
 		Debug(_log, "Inverted: %s, Mode: %d", (_spiDataInvert) ? "yes" : "no", _spiMode);
 
 		if (_defaultInterval > 0)
-			Error(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
+			Warning(_log, "The refresh timer is enabled ('Refresh time' > 0) and may limit the performance of the LED driver. Ignore this error if you set it on purpose for some reason (but you almost never need it).");
 
 		isInitOK = true;
 	}