Add Fate die support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kinda rough, but should work fine. A physical Fate die is a d6 containing two - signs, two + signs, and two blank sides. This is emulated using -1 for the - sign, +1 for the + sign, and a 0 for the blank side. The result is that we can still add them up (so 10dF work), subtract them, keep highest etcetera. Also added a FateLiteral class that's optional, it's just there to make the end result (when looking at `result.expr`) a bit nicer.
|
I couldn't find where the readthedocs site is generated from, but I did update the README, I hope that's enough to tick the "I have updated the documentation to reflect the changes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is kinda rough, but should work fine. A physical Fate die is a d6 containing two - signs, two + signs, and two blank sides. This is emulated using -1 for the - sign, +1 for the + sign, and a 0 for the blank side. The result is that we can still add them up (so 10dF work), subtract them, keep highest etcetera.
Also added a
FateLiteralclass that's optional, it's just there to make the result (when looking atresult. Expr) a bit nicer.Resolves #8
Checklist
PR Type
Other