RavenDB-21653 : fix flaky test - fix race between updating compare ex…

…change value in one session and querying with compare exchange includes in a different session - wait for last cluster transaction index before the query
aviv86 · Nov 30, 2023 · 837952a · 837952a
1 parent fac5eff
commit 837952a
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/test/SlowTests/Issues/RavenDB_14006.cs b/test/SlowTests/Issues/RavenDB_14006.cs
@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
 using FastTests;
@@ -412,7 +413,7 @@ public void CanUseCompareExchangeValueIncludesInQueries_Dynamic()
         }
 
         [Fact]
-        public void CanUseCompareExchangeValueIncludesInQueries_Dynamic_JavaScript()
+        public async Task CanUseCompareExchangeValueIncludesInQueries_Dynamic_JavaScript()
         {
             using (var store = GetDocumentStore())
             {
@@ -476,14 +477,20 @@ select incl(c)"
                     Assert.Equal(-1, stats.DurationInMs); // from cache
                     Assert.Equal(resultEtag, stats.ResultEtag);
 
+                    long lastClusterTxIndex;
+                    var database = await Databases.GetDocumentDatabaseInstanceFor(store);
+
                     using (var innerSession = store.OpenSession(new SessionOptions { TransactionMode = TransactionMode.ClusterWide }))
                     {
                         var value = innerSession.Advanced.ClusterTransaction.GetCompareExchangeValue<Address>(companies[0].ExternalId);
                         value.Value.City = "Bydgoszcz";
 
                         innerSession.SaveChanges();
+                        lastClusterTxIndex = value.Index;
                     }
 
+                    await database.RachisLogIndexNotifications.WaitForIndexNotification(lastClusterTxIndex, TimeSpan.FromSeconds(5));
+
                     companies = companies = session.Advanced
                         .RawQuery<Company>(
                         @"