Added SHA3 and Keccak-256 #3
Conversation
| // Return the hash. | ||
| // TODO: Should probably rename this | ||
| checkSum() : [Nat8]; |
There was a problem hiding this comment.
It there are reason this was added to the Hash interface?
There was a problem hiding this comment.
I added it to avoid repeating myself in the SHA3_* by reusing New. The checkSum function in SHA2.mo seemed to be the main part of the hashing too. Thought it'd be good to add. I can define the parameters like H256 instead though.
| @@ -21,6 +21,8 @@ module HMAC { | |||
|
|
|||
| public func size() : Nat { outer.size() }; | |||
|
|
|||
| public func checkSum() : [Nat8] { [0] }; | |||
| private func dump() { | ||
| Debug.print("State"); | ||
| for (i in Iter.range(0, state.size()-1)) { | ||
| let b = Array.reverse<Nat8>(unpack64(state[i])); | ||
| Debug.print(Hex.encode(b)); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Thought I'd leave it, in case more testing (and debugging) need to be done. Easier to have it and ask to remove IMHO. Can remove it no problem.
| state[pt/8] ^= Nat64.fromNat(Nat8.toNat(delimitedSuffix)) << Nat64.fromNat((pt%8)*8); | ||
| state[(rsize-1:Nat)/8] ^= 0x80 : Nat64 << Nat64.fromNat(((rsize-1):Nat%8)*8); | ||
|
|
||
| //dump(); |
| pt := 0; | ||
| }; | ||
| }; | ||
| //dump(); |
|
|
||
| import Keccak_256 "../src/SHA/Keccak_256"; | ||
|
|
||
| //Debug.print("Testing Keccak_256"); |
There was a problem hiding this comment.
Should either be removed or uncommented (same for other print statements).
There was a problem hiding this comment.
To me, these served more as comments about describing the tests and to break them up. Safe to assume you want them removed as the other tests don't emit any messages?
| }; | ||
|
|
||
| // Function to update internal state with content | ||
| // TODO: should data be a blob? Sticking with Array from Hash type |
There was a problem hiding this comment.
Once you can get individual bytes out of a blob, the whole package will migrate to it.
Currently blobs do not allow you to do much.
There was a problem hiding this comment.
Good to know. I'll drop the comment.
Proposed Changes
checkSumtoHashtype to simplifysumfunctions for DRY (IIRC)