Add transactions #30
Closed
Add transactions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml
src/main.rs
Outdated
| depositor_address: send.depositor_address, | ||
| receiver_address: send.receiver_address, | ||
| amount: send.amount, | ||
| // claim_type: send.claim_type, |
There was a problem hiding this comment.
should we remove this one? or keep it, just because?
luka-ethernal
approved these changes
Oct 28, 2024
QEDK
requested changes
Oct 28, 2024
| #[serde_as] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct TransactionData { | ||
| pub message_id: i64, |
| pub message_id: i64, | ||
| pub status: StatusEnum, | ||
| pub source_transaction_hash: String, | ||
| pub source_block_number: i64, |
| pub status: StatusEnum, | ||
| pub source_transaction_hash: String, | ||
| pub source_block_number: i64, | ||
| pub source_block_hash: String, |
| pub source_block_number: i64, | ||
| pub source_block_hash: String, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub source_transaction_index: Option<i64>, |
| pub source_transaction_index: Option<i64>, | ||
| #[serde_as(as = "TimestampSeconds")] | ||
| pub source_timestamp: NaiveDateTime, | ||
| pub token_id: String, |
| #[derive(Debug, Default, Serialize, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct TransactionResult { | ||
| pub avail_send: Vec<TransactionData>, |
| pub destination_timestamp: Option<NaiveDateTime>, | ||
| pub depositor_address: String, | ||
| pub receiver_address: String, | ||
| pub amount: String, |
| [( | ||
| "Cache-Control", | ||
| format!( | ||
| "public, max-age={}, immutable", |
There was a problem hiding this comment.
immutable and maxage should be set only when both dest and source vars are set. Otherwise, should be considered fresh for 5 minutes (or some duration less than bridging duration).
| #[diesel(sql_type = ClaimType)] | ||
| #[derive(Serialize, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub enum ClaimTypeEnum { |
| impl FromSql<Status, Pg> for StatusEnum { | ||
| fn from_sql(bytes: PgValue<'_>) -> deserialize::Result<Self> { | ||
| match bytes.as_bytes() { | ||
| b"IN_PROGRESS" => Ok(StatusEnum::InProgress), |
There was a problem hiding this comment.
Should be PENDING, SENT, PROCESSED or similar IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transactions endpoint.