Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion PR: Recover Protocol Sequence and Refactor Bridge Nonce #73

Merged
merged 19 commits into from
Mar 15, 2024

Conversation

fmiguelgarcia
Copy link
Collaborator

@fmiguelgarcia fmiguelgarcia commented Feb 19, 2024

Description

This is a companion PR of "Recover Protocol Sequence and Bridge Nonce Refactor".
The main changes are:

  • Header types and bounds were simplified.
  • AppExtrinsic now contains the Transaction Idx. Some unused code was removed too.
  • AppUncheckedExtrinsic enforces Codec on Account, Call, and Signature.

Important Changes

  • Dependency Issues Solved: Remove multiple versions of sp_std, sp-runtime-interface, sp-debug-derive, sp-externalities, sp-storage, sp-tracing, rand, rand-chacha.
  • Update substrate to v1.7.1-patch.
  • Use workspace deps.
  • ❗ Use sp-crypto-ec-utils from polkadot-v1.7.1-patch branch.
  • ℹ️ Replace ethabi by ethabi-decode due to its no-std support.
  • ⚙️ Performance: EvaluationGrid groups by AppId with no-copies.

@fmiguelgarcia fmiguelgarcia self-assigned this Feb 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 74.62687% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 66.57%. Comparing base (79a0cbf) to head (7eefec6).

Files Patch % Lines
core/src/header/mod.rs 31.25% 22 Missing ⚠️
core/src/data_proof_v2/message.rs 79.03% 13 Missing ⚠️
core/src/asdr.rs 26.66% 11 Missing ⚠️
kate/examples/multiproof_verification.rs 0.00% 10 Missing ⚠️
core/src/data_proof_v2/message_ref.rs 90.00% 9 Missing ⚠️
core/src/data_proof_v2.rs 92.85% 2 Missing ⚠️
core/src/opaque_extrinsic.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   66.42%   66.57%   +0.14%     
==========================================
  Files          37       39       +2     
  Lines        6028     6213     +185     
==========================================
+ Hits         4004     4136     +132     
- Misses       2024     2077      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmiguelgarcia fmiguelgarcia marked this pull request as ready for review March 7, 2024 22:46
@fmiguelgarcia fmiguelgarcia added the enhancement New feature or request label Mar 8, 2024
@fmiguelgarcia fmiguelgarcia merged commit 4b9888b into main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants