-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Companion PR: Recover Protocol Sequence and Refactor Bridge Nonce #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 66.42% 66.57% +0.14%
==========================================
Files 37 39 +2
Lines 6028 6213 +185
==========================================
+ Hits 4004 4136 +132
- Misses 2024 2077 +53 ☔ View full report in Codecov by Sentry. |
Leouarz
approved these changes
Mar 8, 2024
0xSasaPrsic
reviewed
Mar 8, 2024
ToufeeqP
approved these changes
Mar 8, 2024
0xSasaPrsic
reviewed
Mar 12, 2024
0xSasaPrsic
reviewed
Mar 12, 2024
0xSasaPrsic
reviewed
Mar 12, 2024
0xSasaPrsic
reviewed
Mar 12, 2024
0xSasaPrsic
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a companion PR of "Recover Protocol Sequence and Bridge Nonce Refactor".
The main changes are:
Header
types and bounds were simplified.AppExtrinsic
now contains the Transaction Idx. Some unused code was removed too.AppUncheckedExtrinsic
enforcesCodec
onAccount
,Call
, andSignature
.Important Changes
sp_std
,sp-runtime-interface
,sp-debug-derive
,sp-externalities
,sp-storage
,sp-tracing
,rand
,rand-chacha
.v1.7.1-patch
.sp-crypto-ec-utils
frompolkadot-v1.7.1-patch
branch.ethabi
byethabi-decode
due to itsno-std
support.EvaluationGrid
groups byAppId
with no-copies.