chore(core/rawdb): use libevm core/rawdb #772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
commented
Jan 29, 2025
Comment on lines
-253
to
-257
| // DeletePruningDisabled deletes the marker indicating that the node has | ||
| // run with pruning disabled. | ||
| func DeletePruningDisabled(db ethdb.KeyValueStore) error { | ||
| return db.Delete(pruningDisabledKey) | ||
| } |
There was a problem hiding this comment.
This is unused in the entire codebase, should it be removed?
core/rawdb/accessors_chain_test.go
Outdated
| @@ -276,17 +378,12 @@ func TestBlockReceiptStorage(t *testing.T) { | |||
| receipts := []*types.Receipt{receipt1, receipt2} | |||
|
|
|||
| // Check that no receipt entries are in a pristine database | |||
| header := &types.Header{Number: big.NewInt(0), Extra: []byte("test header")} | |||
| hash := header.Hash() | |||
| hash := common.BytesToHash([]byte{0x03, 0x14}) | |||
There was a problem hiding this comment.
This is original geth code, testing less things - is this ok to remove the additional checks we had added? 🤔 I suppose worth it anyway, but I wanted to double check still.
There was a problem hiding this comment.
seems fine, if in doubt we can replicate the tests in an ext package.
qdm12
force-pushed
the
qdm12/core/rawdb-geth-closer
branch
from
bea1090 to
269a49b
Compare
qdm12
force-pushed
the
qdm12/core/rawdb-geth-closer
branch
from
269a49b to
d49dee5
Compare
- Add geth switch cases - Add geth ancient freezers checks - Add geth only elements of accounted meta - Keep geth-only stats entries removed
qdm12
force-pushed
the
qdm12/core/rawdb-geth-closer
branch
from
a12a415 to
f9ba5bf
Compare
qdm12
changed the title
qdm12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ReadBlock's use of extras andInspectDatabaseHow this works
You might want to review the PR commit by commit.
InspectDatabase: see ava-labs/libevm@c0f677cWithExtrablock hook in libevm to inject body extras in block - see ava-labs/libevm@aca197aHow this was tested
CI passing
Need to be documented?
No
Need to update RELEASES.md?
No