Fix (de)serialization of transferable outputs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the (de)serialization of tranferable outputs by refactoring outputs to be represented by an enum instead of two `Option` fields. This refactoring has several advantages: - Allows the use of `#[serde(untagged)]` for (de)serializing outputs - Makes it explicit that one of the two output types has to be present (before, deserialization could succeed if the output field could not be parsed) - Simplifies code that handles outputs This change also removes some of the code repetition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the (de)serialization of tranferable outputs by refactoring outputs to be represented by an enum instead of two
Optionfields. This refactoring has several advantages:#[serde(untagged)]for (de)serializing outputsThis change also removes some of the code repetition