feat: convert autoware_auto_msg to autoware_msg #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/delete_autoware_auto_msg_for_calibration_tool
7 tasks
…ndation/autoware_tools into feat/delete_autoware_auto_msg_for_calibration_tool
…github.com:autowarefoundation/autoware_tools into feat/delete_autoware_auto_msg_for_calibration_tool
github-actions
bot
removed
component:common
component:simulation
component:system
labels
SakodaShintaro
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Basically, I think there's no problem. Especially localization/deviation_estimator is fine.
As I mentioned in the two comments, you need to make some changes to follow the package name change, but it might be better to fix it in the original branch after merging this pull request into the original branch.
tkimura4
merged commit 51e56e5
into
feature/add_calibration_tool
27 of 29 checks passed
yabuta
added a commit
that referenced
this pull request
Jun 11, 2024
* add vehicle control localization tools * style(pre-commit): autofix * fix pre commit * Fix to pass cspell about localization Signed-off-by: Shintaro Sakoda <[email protected]> * ignore words from spellcheck * ROS2 -> ROS 2 * feat: convert autoware_auto_msg to autoware_msg (#42) * merge * delete autoware_auto * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * add prefix to vehicle_info_utils Signed-off-by: tomoya.kimura <[email protected]> * style(pre-commit): autofix * fix: add s to VehicleInfoUtil Signed-off-by: tomoya.kimura <[email protected]> * fix --------- Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: tomoya.kimura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: tomoya.kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According this discussion, autoware_auto_msgs is converted to autoware_msgs.
I fix autoware_auto_msgs in calibration tool.
Related links
Tests performed
I checked colconb build is success and tools launch test.
While stop_accel_evaluator is mentenance now, only build check
Notes for reviewers
@SakodaShintaro Please check deviation_estimator.
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.