Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_adapi_v1_msgs): add detect area #29

Closed
wants to merge 2 commits into from

Conversation

tkhmy
Copy link
Contributor

@tkhmy tkhmy commented Mar 6, 2023

Description

  • add msgs for detect area

Related links

autowarefoundation/autoware#3225 (comment)
autowarefoundation/autoware-documentation#333

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tkhmy <[email protected]>
@xmfcx
Copy link
Contributor

xmfcx commented Mar 16, 2023

Detect Area name is too ambiguous. I proposed autowarefoundation/autoware#3342 to change the naming in Autoware Universe. Is it ok to continue this after we decide on the name?

@tkhmy
Copy link
Contributor Author

tkhmy commented Mar 16, 2023

Detect Area name is too ambiguous. I proposed autowarefoundation/autoware#3342 to change the naming in Autoware Universe. Is it ok to continue this after we decide on the name?

@xmfcx You mean the detection_area from the planning?

Yes, I do agree that the detection_area need to be rename.

For this api, actually I mean for the detect area that planning is looking at, it will cover the following area

  • blind spot
  • crosswalk
  • detection_area
  • intersection
  • merge_from_private
  • no_stopping_area
  • walkway

I think this api also need to rename to a better phrase

@xmfcx
Copy link
Contributor

xmfcx commented Mar 17, 2023

Hmm, then maybe PlanningZone and PlanningZoneArray could be good message names. What do you think?

cc: @TakaHoribe @mitsudome-r @isamu-takagi @mehmetdogru @takayuki5168 @kosuke55

@tkhmy
Copy link
Contributor Author

tkhmy commented Mar 17, 2023

Hmm, then maybe PlanningZone and PlanningZoneArray could be good message names. What do you think?

cc: @TakaHoribe @mitsudome-r @isamu-takagi @mehmetdogru @takayuki5168 @kosuke55

Ya, I think PlanningZone and PlanningZoneArray will be a good message name. If no other commend, I think I will change to it

Signed-off-by: tkhmy <[email protected]>
@tkhmy
Copy link
Contributor Author

tkhmy commented Mar 23, 2023

@xmfcx Hi, sorry for the long wait, I changed the naming to PlanningArea, I think Area will be much common phrases for autoware.

@tkhmy
Copy link
Contributor Author

tkhmy commented Aug 23, 2023

@isamu-takagi cc: @yabuta @yuasabe
As this task is not going to develop by my side, so I will close this pr.

@tkhmy tkhmy closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants