Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): integrate cuda/no-cuda jobs into single job #5363

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Oct 23, 2024

Description

Resolved #5082

As a result of the activity autowarefoundation/autoware.universe#8695, the only packages dependent on CUDA are the sensing/perception components of autoware.universe. Therefore, the container images with the -cuda suffix are actually only needed for universe-sensing-perception-devel and universe-sensing-perception.

Additionally, since there is currently only one arm64 self-hosted runner, the no-cuda/cuda jobs in the docker-build-and-push-arm64 workflow experience double the waiting time.

This PR consolidates the no-cuda/cuda jobs and changes the process so that only the CUDA dependent packages in the sensing/perception component are built in an additional stage.

Dockerfile

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/11489943171
https://github.com/autowarefoundation/autoware/actions/runs/11489945134

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 0c7459d.
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Oct 23, 2024
@youtalk youtalk self-assigned this Oct 23, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk force-pushed the upstream-refine-cuda-workflow branch from d63ab93 to 37adf25 Compare October 23, 2024 21:44
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk marked this pull request as ready for review October 23, 2024 22:10
Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Build the CUDA packages with the sensing/perception container as the parent
1 participant