-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): integrate cuda
/no-cuda
jobs into single job
#5363
Open
youtalk
wants to merge
21
commits into
main
Choose a base branch
from
upstream-refine-cuda-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 0c7459d.
youtalk
added
type:containers
Docker containers, containerization of components, or container orchestration.
component:openadkit
Issues or Features related to Open AD Kit
tag:run-health-check
Run health-check
labels
Oct 23, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
youtalk
force-pushed
the
upstream-refine-cuda-workflow
branch
from
October 23, 2024 21:44
d63ab93
to
37adf25
Compare
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:openadkit
Issues or Features related to Open AD Kit
tag:run-health-check
Run health-check
type:containers
Docker containers, containerization of components, or container orchestration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved #5082
As a result of the activity autowarefoundation/autoware.universe#8695, the only packages dependent on CUDA are the
sensing/perception
components ofautoware.universe
. Therefore, the container images with the-cuda
suffix are actually only needed foruniverse-sensing-perception-devel
anduniverse-sensing-perception
.Additionally, since there is currently only one arm64 self-hosted runner, the
no-cuda/cuda
jobs in thedocker-build-and-push-arm64
workflow experience double the waiting time.This PR consolidates the
no-cuda/cuda
jobs and changes the process so that only the CUDA dependent packages in thesensing/perception
component are built in an additional stage.Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/11489943171
https://github.com/autowarefoundation/autoware/actions/runs/11489945134
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.