Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add roi_pointcloud_fusion #438

Conversation

badai-nguyen
Copy link
Contributor

Description

Update node diagram regarding PR #4681

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@stale
Copy link

stale bot commented Oct 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 20, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen
Is this correct? I think roi_pointcloud_fusion output roi_cluster/clusters and cluster_merger is added.

image

@miursh
Copy link
Contributor

miursh commented Oct 26, 2023

Ah, sorry I get it. This PR is a bit old one....

@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Oct 26, 2023

@miursh I am sorry, this PR was created before changing to roi_based_clustering. I will check and update it.

@badai-nguyen
Copy link
Contributor Author

I close this since it is fixed here #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants