Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-interface): add component interface list #279

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

isamu-takagi
Copy link
Contributor

Signed-off-by: Takagi, Isamu [email protected]

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Dec 14, 2022
@isamu-takagi isamu-takagi added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 14, 2022

interfaces:
- name: /localization/initialization_state
type: autoware_adapi_v1_msgs/msg/LocalizationInitializationState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making it independent of autoware_adapi_v1_msgs?
I think it would be better to close the interaction between components to component interface msgs only.

Copy link
Contributor Author

@isamu-takagi isamu-takagi Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either is fine. We can separate it now for consistency, or copy and edit it later when we need. Is it better to separate now?

Signed-off-by: Takagi, Isamu <[email protected]>
@stale
Copy link

stale bot commented Mar 19, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 19, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Jul 21, 2023

I've just seen this list, thanks for working on this.

I have some long-term ideas about this topic.

Having a documentation for these interfaces is great. But keeping this document up-to-date or have it reflect the latest changes it challenging.

Maybe we can create a tool to dynamically analyze the Autoware to ensure:

  • Each component uses the correct message types to communicate
    • To achieve this,
      • when the Autoware is running (with awsim for example),
      • go through each topic,
      • check the publisher node type,
      • check the subscriber node types,
      • check if the nodes belong to the correct component group
      • list the topics that don't belong to any component
      • list the topics that don't use the listed(acceptable) types

This would require a lot of work and needs to be thought thoroughly. @isamu-takagi what do you think?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 21, 2023
Signed-off-by: Takagi, Isamu <[email protected]>
@stale
Copy link

stale bot commented Oct 22, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants