-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block_with_iommu: expands the test case functionality #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingwangrh
reviewed
Oct 30, 2024
qingwangrh
reviewed
Oct 30, 2024
mcasquer
force-pushed
the
2991_block_iommu_reboot
branch
from
October 30, 2024 07:04
b43ee14
to
82e8624
Compare
|
mcasquer
force-pushed
the
2991_block_iommu_reboot
branch
from
October 31, 2024 09:50
82e8624
to
8a602e8
Compare
@qingwangrh do you think current patch code is fine ? Then I will request the maintainers for review, thanks ! |
mcasquer
force-pushed
the
2991_block_iommu_reboot
branch
2 times, most recently
from
November 4, 2024 07:39
f0c1f59
to
2e37335
Compare
qingwangrh
approved these changes
Nov 4, 2024
@YongxueHong @zhencliu could you review this PR? Thanks ! |
YongxueHong
reviewed
Nov 12, 2024
mcasquer
force-pushed
the
2991_block_iommu_reboot
branch
from
November 12, 2024 08:27
2e37335
to
ba9ed0f
Compare
Expands the test case functionality, doing a simple i/o operation after checking the guest has boot up successfully and finally reboot the VM in all the cases. Signed-off-by: mcasquer <[email protected]>
mcasquer
force-pushed
the
2991_block_iommu_reboot
branch
from
November 12, 2024 08:28
ba9ed0f
to
6180958
Compare
Tests passed (without iothread)
|
YongxueHong
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
zhencliu
approved these changes
Nov 12, 2024
hi @qingwangrh , would you please have a double check? |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block_with_iommu: expands the test case functionality
Expands the test case functionality, doing a simple i/o
operation after checking the guest has boot up
successfully and finally reboot the VM in all the cases.
Signed-off-by: mcasquer [email protected]
ID: 2991