Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update deps & fix fastify warnings #5

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: update deps & fix fastify warnings #5

merged 1 commit into from
Jan 18, 2024

Conversation

meghein
Copy link
Contributor

@meghein meghein commented Jan 12, 2024

Summary

  • Update dependencies
  • Replace lint tool - @autotelic/eslint-config-js instead of standard
  • Update validate and release workflows
  • Fix fastify warnings
  • Update tests
  • Update node version

Test Plan

  • Run tests - there should not be any fastify warnings
  • To test out a consumer, run tests for any project that is using fastify-injector, for example fastify-openapi-autoload. Confirm the async/await warnings surface.
  • Switch the version of fastify-injector from "0.2.0" to "github:autotelic/fastify-injector#feat/update" and install
  • Run the tests again and confirm warnings are no longer present

@meghein meghein requested a review from HW13 January 16, 2024 19:10
eadmundo
eadmundo approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@eadmundo eadmundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using in fasdentify-v2, works a treat! LGTM 😅

HW13
HW13 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@HW13 HW13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎 👍

@meghein meghein merged commit 1e3eed4 into main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HW13 HW13 HW13 approved these changes

@eadmundo eadmundo eadmundo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meghein @eadmundo @HW13