Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial setup #2

Merged
merged 3 commits into from
Jan 25, 2024
Merged

feat: initial setup #2

merged 3 commits into from
Jan 25, 2024

Conversation

meghein
Copy link
Contributor

@meghein meghein commented Jan 24, 2024

Summary

  • Install @fast-csv/parse @fastify/multipart and ajv
  • Configure plugin to decorate fastify with csvImport

Test Plan

  • Install dependencies with npm
  • Run example app with node:
node ./example/index.js
  • In a separate terminal, make the following requests:
http -f POST :3000/csv/import file@example/fixtures/valid-products.csv # should respond with an array of products
http -f POST :3000/csv/import file@example/fixtures/large-file.csv # should return an error with appropriate message 
http -f POST :3000/csv/import file@example/fixtures/invalid-fixed-price.csv # should return an error with appropriate message 

Copy link
Contributor

@markdeleon-autotelic markdeleon-autotelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meghein meghein merged commit 2f9bf29 into main Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants