Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add request object to method calls #55

Merged
merged 1 commit into from
Oct 24, 2023
Merged

add request object to method calls #55

merged 1 commit into from
Oct 24, 2023

Conversation

eadmundo
Copy link
Member

@eadmundo eadmundo commented Oct 6, 2023 •
edited
Loading

Summary

  • adds request object to cloudprnt calls to enable e.g. identifying printer by mac address

Test Plan

  • test in conjunction wth autotelic/newco#1523

@eadmundo eadmundo marked this pull request as ready for review October 10, 2023 19:58
CLSnazel
CLSnazel approved these changes Oct 24, 2023
View reviewed changes
Copy link

@CLSnazel CLSnazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eadmundo eadmundo merged commit c663c55 into main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CLSnazel CLSnazel CLSnazel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eadmundo @CLSnazel