refactor: rename neps.XParameter to neps.X
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiebergman
approved these changes
Oct 18, 2024
| @@ -49,7 +50,7 @@ def run_pipeline( # (1)! | |||
| ) | |||
|
|
|||
| return { | |||
| "loss": validation_error, #! (2) | |||
| "loss": validation_error, # ! (2) | |||
There was a problem hiding this comment.
Did you check that adding this leading whitespace still leads to correct rendering with the docs? You'd have to run mkdocs serve and check.
There was a problem hiding this comment.
Thanks for letting me know! I checked the generated docs and compared with the current ones and I see no issues with the rendered page after introduction of this whitespace. I think this was introduced during pre-commit run
I used Copilot button on PR to summarize the introduced changes (https://githubnext.com/projects/copilot-for-pull-requests)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the update to
neps.XParameterclasses and replaces them with the newneps.Xclasses, while maintaining backwards compatibility forneps.XParameterusage. Deprecation warnings have been introduced forneps.XParameterclasses to inform the users of the changes and advise them to update their code accordingly.Renaming Parameter Classes:
README.md,docs/index.md,docs/getting_started.md,docs/doc_yamls/architecture_search_space.py: Updated parameter class names fromFloatParameter,IntegerParameter,CategoricalParameter, andConstantParametertoFloat,Integer,Categorical, andConstant, respectively. [1] [2] [3] [4]docs/reference/pipeline_space.md: Reflected the new parameter class names in the documentation. [1] [2] [3]Source Code Updates:
neps/__init__.py: Removed old parameter class aliases and added new ones to the import list.neps/api.py,neps/optimizers/grid_search/optimizer.py,neps/optimizers/multi_fidelity/ifbo.py,neps/optimizers/multi_fidelity/successive_halving.py,neps/optimizers/multi_fidelity_prior/utils.py,neps/sampling/priors.py: Updated references to the renamed parameter classes. [1] [2] [3] [4] [5] [6]Import Adjustments:
neps/search_spaces/__init__.py: Adjusted imports to include the newly named parameter classes.These changes ensure consistency across the codebase and documentation, making the parameter class names more intuitive and easier to understand.