Skip to content

Commit

Permalink
removed search space from algorithm class and fixed hyperparameter na…
Browse files Browse the repository at this point in the history
…ming
  • Loading branch information
LabChameleon committed Jun 5, 2024
1 parent bb0c6b6 commit ed05c99
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
12 changes: 0 additions & 12 deletions arlbench/core/algorithms/algorithm.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,6 @@ def get_hpo_config_space(seed: int | None = None) -> ConfigurationSpace:
ConfigurationSpace: Hyperparameter configuration space of the algorithm.
"""

@staticmethod
@abstractmethod
def get_hpo_search_space(seed: int | None = None) -> ConfigurationSpace:
"""Returns the hyperparameter search space of the algorithm. However, this can be adapted to fit a given HPO method.
Args:
seed (int | None, optional): Random generator seed that is used to sample configurations. Defaults to None.
Returns:
ConfigurationSpace: Hyperparameter search space of the algorithm.
"""

@staticmethod
@abstractmethod
def get_default_hpo_config() -> Configuration:
Expand Down
2 changes: 1 addition & 1 deletion arlbench/core/algorithms/dqn/dqn.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def get_hpo_config_space(seed: int | None = None) -> ConfigurationSpace:
"tau": Float("tau", (0.01, 1.0), default=1.0),
"initial_epsilon": Float("initial_epsilon", (0.5, 1.0), default=1.0),
"target_epsilon": Float("target_epsilon", (0.001, 0.2), default=0.05),
"exploration_fraction": Float("initial_epsilon", (0.005, 0.5), default=0.1),
"exploration_fraction": Float("exploration_fraction", (0.005, 0.5), default=0.1),
"use_target_network": Categorical(
"use_target_network", [True, False], default=True
),
Expand Down

0 comments on commit ed05c99

Please sign in to comment.