Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PriorAcquisitionFunction #1185

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Dec 23, 2024

Im this MR I will adapt the PriorAcquisitionFunction.

This contains fixes for #1076

@LukasFehring LukasFehring changed the title Dummy commit to create Draft MR Fix PriorAcquisitionFunction Dec 23, 2024
@LukasFehring LukasFehring marked this pull request as draft December 23, 2024 12:46
@LukasFehring
Copy link
Collaborator Author

I just found an additional problem: if discretize==True the floor is added twice.

@LukasFehring LukasFehring self-assigned this Jan 13, 2025
@LukasFehring LukasFehring marked this pull request as ready for review January 13, 2025 08:23
@LukasFehring LukasFehring linked an issue Jan 13, 2025 that may be closed by this pull request
@LukasFehring LukasFehring force-pushed the 1076-fix-priorAcquisitionFunction branch from 74fb4c9 to 3ebdaf3 Compare January 13, 2025 12:14
@mwever mwever self-requested a review January 13, 2025 12:33
Copy link

@mwever mwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamc benjamc merged commit aed7769 into development Jan 13, 2025
11 checks passed
@benjamc benjamc deleted the 1076-fix-priorAcquisitionFunction branch January 13, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iteration_number in PriorAcquisitionFunction()
3 participants