Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the reference for changes being emitted by Watch #2232

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove the reference for changes being emitted by Watch #2232

merged 1 commit into from
Feb 3, 2025
+76 −68

Conversation

josephschorr
Copy link
Member

A change should always be found in the channel, so there is little benefit to it being a reference

@josephschorr josephschorr requested review from vroldanbet and a team as code owners February 3, 2025 18:24
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Feb 3, 2025
@josephschorr josephschorr requested review from tstirrat15 and removed request for vroldanbet February 3, 2025 19:10
@josephschorr
Remove the reference for changes being emitted by Watch
a41323f 
A change should always be found in the channel, so there is little benefit to it being a reference
tstirrat15
tstirrat15 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own edification: the idea is that this prevents nil pointer derefs and also means that if the struct is small enough and the go runtime deems it appropriate, it may allocate it on the stack instead of the heap.

@tstirrat15 tstirrat15 added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@josephschorr josephschorr added this pull request to the merge queue Feb 3, 2025
Merged via the queue into authzed:main with commit 1a3888d Feb 3, 2025
39 checks passed
@josephschorr josephschorr deleted the deref-changes branch February 3, 2025 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @tstirrat15