Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement partials syntax parsing #2211

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement partials syntax parsing #2211

wants to merge 9 commits into from
+374 −7

Conversation

tstirrat15
Copy link
Contributor

Description

Part of the MVP of composable schema support. This implements the parsing part of a partials syntax, which can be used to decompose a schema within definitions.

Changes

  • Add partial as a keyword
  • Implement parsing of partials blocks
  • Implement parsing of partial references
  • Add tests

@tstirrat15 tstirrat15 marked this pull request as ready for review January 24, 2025 18:35
@tstirrat15 tstirrat15 requested a review from a team as a code owner January 24, 2025 18:35
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 24, 2025
josephschorr
josephschorr reviewed Jan 24, 2025
View reviewed changes
pkg/composableschemadsl/parser/parser.go Outdated
partialNode := p.startNode(dslshape.NodeTypePartial)
defer p.mustFinishNode()

// definition ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephschorr josephschorr josephschorr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstirrat15 @josephschorr