Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger from context in RedactAndLogSensitiveConnString #1686

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Use logger from context in RedactAndLogSensitiveConnString #1686

merged 1 commit into from
Dec 18, 2023

Conversation

bison
Copy link
Member

@bison bison commented Dec 18, 2023

Changes the constructors for the various datastores to take contexts, and uses the logger from the context when reporting initialization errors.

@bison bison requested a review from vroldanbet as a code owner December 18, 2023 13:59
@bison bison requested a review from a team December 18, 2023 13:59
@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Dec 18, 2023
@bison
Use logger from context in RedactAndLogSensitiveConnString
3734352 
Changes the constructors for the various datastores to take contexts,
and uses the logger from the context when reporting initialization
errors.
@bison bison enabled auto-merge December 18, 2023 16:29
@bison bison added this pull request to the merge queue Dec 18, 2023
Merged via the queue into authzed:main with commit 406e2bb Dec 18, 2023
20 checks passed
@bison bison deleted the db-errors-ctx branch December 18, 2023 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bison @vroldanbet