make datastore metrics more representative of the actual underlying datastore #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atastore the datastore metrics proxy was installed after various other proxies that try to help with datastore performance, namely caching and deduplication. If the proxy is installed after those, the metrics obtained do not reflect the actual latencies and requests to the datastore: - latencies will be lower thanks to caching and deduplication - actual datastore calls will be higher that they actually are because some requests may never hit the datastore Given how important is the access to the datastore for the latency and throughput of the application, this moves the proxy so it measures actual calls to the datastore by moving it around the proxy chain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the datastore metrics proxy was installed after various other proxies that try to help with datastore performance, namely caching, and deduplication. If the proxy is installed after those, the metrics obtained do not reflect the actual latencies and requests to the datastore:
Given how important is access to the datastore for the latency and throughput of the application, this moves the proxy so it measures actual calls to the datastore by moving it around the proxy chain.