Fix handling of NULL caveats in Postgres watch #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, the Postgres driver sets the caveat name column to empty string when no caveat is present. However, the field IS nullable and bulk import can set it to a NULL instead. The watch API code therefore needs to support this scenario
github-actions
bot
added
area/datastore
ecordell
approved these changes
Nov 30, 2023
vroldanbet
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, the Postgres driver sets the caveat name column to empty string when no caveat is present. However, the field IS nullable and bulk import can set it to a NULL instead.
The watch API code therefore needs to support this scenario