Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PhoneNumber as a flexible identifier #746

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

kailash-b
Copy link
Contributor

@kailash-b kailash-b commented Nov 13, 2024

Changes

Authentication :

  • Addition of PhoneNumber field in SignUpRequest and SignUpResponse in dbconnections/signup endpoint.
  • Added ConnectionOptions model for use in ConnectionCreateRequest and ConnectionUpdateRequest (/api/v2/connections/{id} endpoints).

References

Testing

Following test cases added/modified :

  • Modified Test_connection_crud_sequence to now include Options parameter during create and update operations. All the fields and sub-fields in Options are populated and the response is validated against the request.

  • Added a new test Can_signup_user_with_phonenumber to test if we can sign-up using a connection that supports PhoneNumber.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner November 13, 2024 11:36
@kailash-b kailash-b merged commit 4e6f245 into master Nov 13, 2024
11 checks passed
@kailash-b kailash-b deleted the feature/flex-identifiers/SDK-5145 branch November 13, 2024 13:58
@kailash-b kailash-b mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants