Fetch clients if not defined in client grants YAML handler #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
While troubleshooting #855, I noticed that for YAML exports, an exported client grant wouldn't have the
client_id
swapped with its correlating client's name if the clients didn't exist in theassets
object. This should be fairly rare but still technically possible in cases where you're excluding clients from the management purview.🔬 Testing
Added two new test cases to round-out all possibilities:
assets
object already, client name replace for IDassets
, clients fetched but ID not replaced for name because no correlating client existsassets
, clients fetched and ID replaced for name because correlating client found📝 Checklist