Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch clients if not defined in client grants YAML handler #865

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Nov 20, 2023

🔧 Changes

While troubleshooting #855, I noticed that for YAML exports, an exported client grant wouldn't have the client_id swapped with its correlating client's name if the clients didn't exist in the assets object. This should be fairly rare but still technically possible in cases where you're excluding clients from the management purview.

🔬 Testing

Added two new test cases to round-out all possibilities:

  1. Clients exist on assets object already, client name replace for ID
  2. Clients do not exist on assets, clients fetched but ID not replaced for name because no correlating client exists
  3. Clients do not exist on assets, clients fetched and ID replaced for name because correlating client found

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner November 20, 2023 15:37
@willvedd willvedd enabled auto-merge (squash) November 20, 2023 15:37
@willvedd willvedd merged commit 672094d into master Nov 21, 2023
1 check passed
@willvedd willvedd deleted the fetch-clients-if-undefined-client-grants-handler branch November 21, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants