This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
chore: make log types distinguishable by rendering their value #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #90
✏️ Changes
The list of log types will now contain the log type code in parentheses, so that users can distinguish e.g.
Failed Exchange (feacft)
fromFailed Exchange (feccft)
when they want to select one but not the other.📷 Screenshots
I don't know how to build and run to make a screenshot using the changes, but this if the unusable state before:
🔗 References
See #90:
🎯 Testing
✅ This change only affects visual rendering in a multi-select component.
🚫 This change has been tested in a Webtask
🚫 This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance
🚀 Deployment
✅ This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful you folks should verify the multi-select list in the extension config works.
🔥 Rollback
You should rollback if somebody is overwhelmed with the information about which "Failed Exchange" log type they're selecting or not.
Notes to maintainers (if there are any)
Filling out this PR template took about 1000 times as long as checking out the repo and bulk changing the texts. I hope someone actually cares about this full blown process, or my next PR will be adjusting the template ;-)