Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

chore: make log types distinguishable by rendering their value #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meichstedt
Copy link

Resolves #90

✏️ Changes

The list of log types will now contain the log type code in parentheses, so that users can distinguish e.g. Failed Exchange (feacft) from Failed Exchange (feccft) when they want to select one but not the other.

📷 Screenshots

I don't know how to build and run to make a screenshot using the changes, but this if the unusable state before:
log-types

🔗 References

See #90:

  • The list as presented is almost unusable: too many log types are declared as "Failed Exchange" and can only be differentiated by the value which isn't rendered. Compare e.g. these two.
  • It is unclear to me whether selecting the first entry (rendered as an empty string) will send all logs, or none.

🎯 Testing

✅ This change only affects visual rendering in a multi-select component.

🚫 This change has been tested in a Webtask

🚫 This change has unit test coverage

🚫 This change has integration test coverage

🚫 This change has been tested for performance

🚀 Deployment

✅ This can be deployed any time

🎡 Rollout

In order to verify that the deployment was successful you folks should verify the multi-select list in the extension config works.

🔥 Rollback

You should rollback if somebody is overwhelmed with the information about which "Failed Exchange" log type they're selecting or not.

Notes to maintainers (if there are any)

Filling out this PR template took about 1000 times as long as checking out the repo and bulk changing the texts. I hope someone actually cares about this full blown process, or my next PR will be adjusting the template ;-)

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix This will not be worked on label Apr 16, 2022
@stale stale bot removed the wontfix This will not be worked on label Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The config for filtering Log Types is almost unusable
2 participants