Update put_settings.js to allow longer tld's to be used #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current longest tld is 24 characters as of (https://data.iana.org/TLD/tlds-alpha-by-domain.txt) so the max length should be increased from 6 to 24 to allow all domains to be used
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Description:
-> The current longest tld is 24 characters as of (https://data.iana.org/TLD/tlds-alpha-by-domain.txt) so the max length should be increased from 6 to 24 to allow all domains to be used
What did you change in the code itself?
-> Increased a value in the RegEx to allow longer tlds to be used.
🔗 References
List of official TLD's that should be supported:
https://data.iana.org/TLD/tlds-alpha-by-domain.txt
🎯 Testing
Try the RegEx with a domain that has a longer tld than 6 characters
🚀 Deployment
✅ This can be deployed any time
🖥 Appliance
Note to reviewers: ensure that this change is compatible with the Appliance.