Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rss feed #1343

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/canvas.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@
'enabled' => env('CANVAS_MAIL_ENABLED', false),
],

'description' => env('CANVAS_DESCRIPTION', 'A simple description for your blog.')
];
24 changes: 24 additions & 0 deletions resources/views/feed.blade.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?=
'<?xml version="1.0" encoding="UTF-8"?>' . PHP_EOL
?>
<rss version="2.0">
<channel>
<title><![CDATA[ {{ url("/") }} ]]></title>
<link><![CDATA[ {{ url("/feed") }} ]]></link>
<description><![CDATA[ {{ config("canvas.description") }} ]]>
</description>
<language>{{ app()->getLocale() }}</language>
<pubDate>{{ now() }}</pubDate>
<lastBuildDate>{{ now() }}</lastBuildDate>
@foreach($posts as $post)
<item>
<title><![CDATA[{{ $post->title }}]]></title>
<link>{{ url($post->slug) }}</link>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in the post slug is good, but we should be using the absolute path to the post - which can vary. Depending if someone wants their publication at: /blog, or /news, etc.

You could try to use this config value, but there could still be edge cases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can have two approaches.

  1. we can ask the user to add the static path of the post in the config.
  2. we can make the feed view publishable, so if the user has a custom url he can configure the feed accordingly.

or we can do both.

what do you say about that ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ask the user to add the static path of the post in the config

I don't think specifying a static path per post is a good UX.

we can make the feed view publishable...configure the feed accordingly

Still a heavier lift than what I'd expect as a user. Essentially, I'd like to see it where you can provide a config value in your .env file - we'd also need to take into account other taxonomies (tags/topics) - and then a switch where you can either enable or disable the feature.

<description><![CDATA[{!! $post->summary !!}]]></description>
<author><![CDATA[ {{ $post->user->name }} ]]></author>
<guid>{{ $post->id }}</guid>
<pubDate>{{ $post->published_at->toRssString() }}</pubDate>
</item>
@endforeach
</channel>
</rss>
6 changes: 6 additions & 0 deletions routes/default.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php

use Canvas\Http\Controllers\FeedController;
use Illuminate\Support\Facades\Route;

Route::get('/feed', [FeedController::class, '__invoke'])->name('feed');
2 changes: 2 additions & 0 deletions src/CanvasServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ private function configureRoutes(): void
->group(function () {
$this->loadRoutesFrom(__DIR__.'/../routes/web.php');
});

$this->loadRoutesFrom(__DIR__.'/../routes/default.php');
}

/**
Expand Down
25 changes: 25 additions & 0 deletions src/Http/Controllers/FeedController.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?php

namespace Canvas\Http\Controllers;

use Canvas\Models\Post;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;

class FeedController extends Controller
{
/**
* Handle the incoming request.
*/
public function __invoke(Request $request)
{
$posts = Post::query()
->select('id', 'slug', 'title', 'user_id', 'summary', 'published_at')
->latest()
->published()
->with('user')
->get();

return response()->view('canvas::feed', compact('posts'))->header('Content-Type', 'text/xml');
}
}