-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rss feed #1343
Closed
Closed
Rss feed #1343
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?= | ||
'<?xml version="1.0" encoding="UTF-8"?>' . PHP_EOL | ||
?> | ||
<rss version="2.0"> | ||
<channel> | ||
<title><![CDATA[ {{ url("/") }} ]]></title> | ||
<link><![CDATA[ {{ url("/feed") }} ]]></link> | ||
<description><![CDATA[ {{ config("canvas.description") }} ]]> | ||
</description> | ||
<language>{{ app()->getLocale() }}</language> | ||
<pubDate>{{ now() }}</pubDate> | ||
<lastBuildDate>{{ now() }}</lastBuildDate> | ||
@foreach($posts as $post) | ||
<item> | ||
<title><![CDATA[{{ $post->title }}]]></title> | ||
<link>{{ url($post->slug) }}</link> | ||
<description><![CDATA[{!! $post->summary !!}]]></description> | ||
<author><![CDATA[ {{ $post->user->name }} ]]></author> | ||
<guid>{{ $post->id }}</guid> | ||
<pubDate>{{ $post->published_at->toRssString() }}</pubDate> | ||
</item> | ||
@endforeach | ||
</channel> | ||
</rss> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<?php | ||
|
||
use Canvas\Http\Controllers\FeedController; | ||
use Illuminate\Support\Facades\Route; | ||
|
||
Route::get('/feed', [FeedController::class, '__invoke'])->name('feed'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
|
||
namespace Canvas\Http\Controllers; | ||
|
||
use Canvas\Models\Post; | ||
use Illuminate\Http\Request; | ||
use Illuminate\Routing\Controller; | ||
|
||
class FeedController extends Controller | ||
{ | ||
/** | ||
* Handle the incoming request. | ||
*/ | ||
public function __invoke(Request $request) | ||
{ | ||
$posts = Post::query() | ||
->select('id', 'slug', 'title', 'user_id', 'summary', 'published_at') | ||
->latest() | ||
->published() | ||
->with('user') | ||
->get(); | ||
|
||
return response()->view('canvas::feed', compact('posts'))->header('Content-Type', 'text/xml'); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing in the post slug is good, but we should be using the absolute path to the post - which can vary. Depending if someone wants their publication at: /blog, or /news, etc.
You could try to use this config value, but there could still be edge cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can have two approaches.
or we can do both.
what do you say about that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think specifying a static path per post is a good UX.
Still a heavier lift than what I'd expect as a user. Essentially, I'd like to see it where you can provide a config value in your .env file - we'd also need to take into account other taxonomies (tags/topics) - and then a switch where you can either enable or disable the feature.