-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Documentation #23
Conversation
- explain macro parameters - Include usage example from the "book" draft
@@ -49,7 +49,7 @@ where | |||
} | |||
} | |||
|
|||
/// Canvas for GPU drawing with Vger. See https://github.com/audulus/vger-rs. | |||
/// Canvas for GPU drawing with Vger. See <https://github.com/audulus/vger-rs>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does that warning come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran cargo doc
, it threw a warning (https://doc.rust-lang.org/rustdoc/lints.html#bare_urls). Essentially, as it was it wouldn't actually render into a hyperlink, just a URL text. Adding <>
should make it a hyperlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning page I linked to explains why it doesn't show up unless you try and build the docs locally:
Note that, except for
missing_docs
, these lints are only available when running rustdoc, not rustc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.. thanks for the info!
This seems like a good step. Why not just merge it now? |
It's been two years. Should this be merged or closed? |
@maaku probably rather stale at this point. I'll close it :) |
This is the branch containing my ongoing efforts to help document the library (#10). Please do not merge them yet.
If you have any problems with the docs, please tell me and/or edit the branch.