Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors #247

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update authors #247

merged 1 commit into from
Nov 14, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Nov 14, 2024

Adds @ChristianGeng to the authors in pyproject.toml and LICENSE.

Summary by Sourcery

Chores:

  • Add Christian Geng to the authors list in pyproject.toml and LICENSE.

Copy link
Contributor

sourcery-ai bot commented Nov 14, 2024

Reviewer's Guide by Sourcery

The PR updates the project's author information by adding a new author and modifying an existing author's entry in the project configuration and license files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update author information in project configuration
  • Add Christian Geng as a new author with email
  • Remove email information for Johannes Wagner
pyproject.toml
Update license file
  • Update author information
LICENSE

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please keep the email address for Johannes Wagner to maintain consistency with other author entries
  • The LICENSE file changes are not completely shown in the diff - please ensure the full changes are included
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit ded8df9 into main Nov 14, 2024
10 checks passed
@hagenw hagenw deleted the update-authors branch November 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant